@joannad What you're doing is exactly what we learned in our reactive dogs class and what has worked really well with our girl.
As to the timing of the treat/click...for us at first it was "Yes" (our marker word instead of a clicker) as soon as she saw a trigger and did not react (basically we...